Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12877 )
Change subject: [sentry] enable sentry integration for master stress test ...................................................................... Patch Set 2: Code-Review+1 (6 comments) Just nits at this point. http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/alter_table-randomized-test.cc File src/kudu/integration-tests/alter_table-randomized-test.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/alter_table-randomized-test.cc@122 PS2, Line 122: itest::S Add a using for this? http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc File src/kudu/integration-tests/cluster_itest_util.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1241 PS2, Line 1241: const sentry::MiniSentry* sentry nit: Could we just pass in the Sentry address? http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1254 PS2, Line 1254: // Create an admin role for 'admin' group and grant privilege 'ALL' on server : // to the role. nit: "Create an admin role for the "admin" group specified in mini_sentry.cc. Grant this role all privileges for the server so the admin user can perform any operations required in tests." http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1256 PS2, Line 1256: "admin", "admin" Can you rename one of these to admin-role? It's confusing as is. http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master-stress-test.cc@124 PS2, Line 124: itest:: using here too http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master_failover-itest.cc File src/kudu/integration-tests/master_failover-itest.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master_failover-itest.cc@92 PS2, Line 92: itest:: using here too -- To view, visit http://gerrit.cloudera.org:8080/12877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48aa1bfd0947c645bb81137bb34e6cdfc088cf4 Gerrit-Change-Number: 12877 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 20 Apr 2019 08:51:56 +0000 Gerrit-HasComments: Yes
