Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12877 )
Change subject: [sentry] enable sentry integration for master stress test ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/alter_table-randomized-test.cc File src/kudu/integration-tests/alter_table-randomized-test.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/alter_table-randomized-test.cc@122 PS2, Line 122: >address > Add a using for this? Done http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc File src/kudu/integration-tests/cluster_itest_util.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1241 PS2, Line 1241: > nit: Could we just pass in the Sentry address? Done http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1254 PS2, Line 1254: // perform any operations required in tests. : RETURN_NOT_OK(m > nit: "Create an admin role for the "admin" group specified in mini_sentry.c Done http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1256 PS2, Line 1256: tryGrantOption::D > Can you rename one of these to admin-role? It's confusing as is. Done http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master-stress-test.cc File src/kudu/integration-tests/master-stress-test.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master-stress-test.cc@124 PS2, Line 124: > using here too Done http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master_failover-itest.cc File src/kudu/integration-tests/master_failover-itest.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/master_failover-itest.cc@92 PS2, Line 92: > using here too Done -- To view, visit http://gerrit.cloudera.org:8080/12877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48aa1bfd0947c645bb81137bb34e6cdfc088cf4 Gerrit-Change-Number: 12877 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 22 Apr 2019 05:54:02 +0000 Gerrit-HasComments: Yes
