Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12877 )
Change subject: [sentry] enable sentry integration for master stress test ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12877/4/src/kudu/integration-tests/cluster_itest_util.h File src/kudu/integration-tests/cluster_itest_util.h: http://gerrit.cloudera.org:8080/#/c/12877/4/src/kudu/integration-tests/cluster_itest_util.h@454 PS4, Line 454: : // When Sentry is enabled, set up super privilege for 'admin' group (via : // creating an admin role and grant privilege 'ALL' on server to the role), : // so that 'test-admin' user, as who all integration tests are running, : // belong to 'admin' group can operate on the cluster. > As a user of this function, it isn't clear what super privileges are. Also Done http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.h File src/kudu/integration-tests/cluster_itest_util.h: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.h@458 PS2, Line 458: // belong to 'admin' group can operate on the cluster. : Status SetupAdministratorPrivileges(MiniKdc* kdc, : const HostPort& address); : > If this is tied to ExternalMiniCluster::Start(), did you consider putting i I am hesitate to do that in case there are tests that don't want super privilege for 'test-admin'. This gives flexibility to choose whether super privilege is needed. If you feel strongly otherwise, I can update that. -- To view, visit http://gerrit.cloudera.org:8080/12877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48aa1bfd0947c645bb81137bb34e6cdfc088cf4 Gerrit-Change-Number: 12877 Gerrit-PatchSet: 4 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Apr 2019 06:20:32 +0000 Gerrit-HasComments: Yes
