Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12877 )
Change subject: [sentry] enable sentry integration for master stress test ...................................................................... Patch Set 3: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.h File src/kudu/integration-tests/cluster_itest_util.h: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.h@458 PS2, Line 458: Status SetupSentryPrivilege(MiniKdc* kdc, : const HostPort& address); : : } // namespace itest Seems we will be Kinitted as 'test-admin'? I'm not sure if that's important. Maybe reword as: "Grants all privileges on the 'server1' to the 'admin' user. <explanation about what kinitting as 'test-admin' does and why a user of this function should care>" http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc File src/kudu/integration-tests/cluster_itest_util.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1240 PS2, Line 1240: rename: SetupAdministratorPrivileges http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1244 PS2, Line 1244: Why don't we have to do this for test-admin? http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1257 PS2, Line 1257: (), "admin-role", privilege) Seems like we are trying to be very permissive in granting the admin all on server. Why not grant option enabled? -- To view, visit http://gerrit.cloudera.org:8080/12877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48aa1bfd0947c645bb81137bb34e6cdfc088cf4 Gerrit-Change-Number: 12877 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 22 Apr 2019 21:11:13 +0000 Gerrit-HasComments: Yes
