Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12877 )
Change subject: [sentry] enable sentry integration for master stress test ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12877/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12877/3//COMMIT_MSG@17 PS3, Line 17: KUDU-2279 > Did you mean KUDU-2779 here? Ah, right. Thanks for catching this. http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.h File src/kudu/integration-tests/cluster_itest_util.h: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.h@458 PS2, Line 458: Status SetupSentryPrivilege(MiniKdc* kdc, : const HostPort& address); : : } // namespace itest Added more clarification. > Seems we will be Kinitted as 'test-admin'? It is because all tests using ExternalMiniCluster is kinitted as 'test-admin'. http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc File src/kudu/integration-tests/cluster_itest_util.cc: http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1244 PS2, Line 1244: > Why don't we have to do this for test-admin? This is already created at external_mini_cluster.cc. http://gerrit.cloudera.org:8080/#/c/12877/2/src/kudu/integration-tests/cluster_itest_util.cc@1257 PS2, Line 1257: (), "admin-role", privilege) > Seems like we are trying to be very permissive in granting the admin all on So far, all the tests using this method don't require grant option. If it is no longer the case, we can certainly do that. -- To view, visit http://gerrit.cloudera.org:8080/12877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48aa1bfd0947c645bb81137bb34e6cdfc088cf4 Gerrit-Change-Number: 12877 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Apr 2019 04:35:35 +0000 Gerrit-HasComments: Yes
