Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 )
Change subject: [tserver] Move cell size checking to prepare phase ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13470/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13470/2//COMMIT_MSG@9 PS2, Line 9: It's inefficiency to check cell size in apply phase to consult every : columns of rows > In prepare phase, we can check cell size when decode data from client reque On the other hand, the prepare phase is single-threaded, whereas the apply phase is multithreaded. So, as much work as we can keep off of 'prepare' the better, IMO. Also I think changing semantics to reject the whole request here if one row is bad is likely to break applications. -- To view, visit http://gerrit.cloudera.org:8080/13470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c Gerrit-Change-Number: 13470 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 11 Jun 2019 16:44:57 +0000 Gerrit-HasComments: Yes
