Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 )
Change subject: [tserver] Move cell and probe key size checking to prepare phase ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.h File src/kudu/common/row_operations.h: http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.h@107 PS6, Line 107: // Read one row's column data from 'src_', read result is stored in 'slice'. : // Return bad Status if data is corrupt. : // NOTE: If column data validate error (i.e. column size exceed the limit), only : // set bad Status to 'row_status', and returm Status::OK. Should also add how setting row_status to nullptr or not will affect column size checking. http://gerrit.cloudera.org:8080/#/c/13470/5/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/13470/5/src/kudu/common/row_operations.cc@605 PS5, Line 605: RETURN_NOT_OK(op->split_row->Set(static_cast<int32_t>(tablet_col_idx), data)); > Not check, because it's a split key, which will not stored in database. Right, and a split key will get validated when, after it's been serialized into a PartitionPB and stored in a SysTabletsEntryPB, the master tablet writes the SysTabletsEntryPB. At that point, the entire SysTabletsEntryPB is written out as a STRING and will get checked via the standard INSERT or UPDATE code paths. http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.cc@421 PS6, Line 421: if (!row_status.ok()) op->SetFailureStatusOnce(row_status); Could PREDICT_FALSE here. http://gerrit.cloudera.org:8080/#/c/13470/6/src/kudu/common/row_operations.cc@518 PS6, Line 518: if (!row_status.ok()) op->SetFailureStatusOnce(row_status); Could PREDICT_FALSE here. -- To view, visit http://gerrit.cloudera.org:8080/13470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c Gerrit-Change-Number: 13470 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Mon, 29 Jul 2019 18:37:05 +0000 Gerrit-HasComments: Yes
