Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/13470 )
Change subject: [tserver] Move cell and probe key size checking to prepare phase ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/13470/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13470/2//COMMIT_MSG@9 PS2, Line 9: It's inefficiency to check cell and probe key size in apply phase, : because we have > On the other hand, the prepare phase is single-threaded, whereas the apply Done http://gerrit.cloudera.org:8080/#/c/13470/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/13470/2/src/kudu/tablet/tablet.cc@545 PS2, Line 545: } : __builtin_unreachable(); : } : : Sta > I think we should, return error as early as possible is reasonable. Done -- To view, visit http://gerrit.cloudera.org:8080/13470 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c Gerrit-Change-Number: 13470 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Sat, 27 Jul 2019 16:10:50 +0000 Gerrit-HasComments: Yes
