Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13470 )

Change subject: [tserver] Move cell size checking to prepare phase
......................................................................


Patch Set 3:

> Patch Set 2:
>
> Does this change user-facing behavior? Previously, if there were a too-large 
> cell in a batch with other valid rows, would the other rows succeed (and the 
> error get reported as a per-row error?)

Per-row error in prepare phase is supported by a prior patch, now we can record 
an error when cell size exceed in prepare phase, user-facing behavior is not 
changed.


--
To view, visit http://gerrit.cloudera.org:8080/13470
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3e672272bb1dcf2d0ac1d96ee8a1a2d1489774c
Gerrit-Change-Number: 13470
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Sat, 27 Jul 2019 10:31:13 +0000
Gerrit-HasComments: No

Reply via email to