Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 )
Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13661/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13661/1//COMMIT_MSG@8 PS1, Line 8: Doc for this feature. http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc File src/kudu/tablet/delta_store.cc: http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc@205 PS1, Line 205: if (may_have_deltas_) { I think we should add some doc here to show that this variable represents whether there is has delta in the last batch. -- To view, visit http://gerrit.cloudera.org:8080/13661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I799e81fef759d22f14d4530dbf0b250e0d7bc69b Gerrit-Change-Number: 13661 Gerrit-PatchSet: 1 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2019 09:08:43 +0000 Gerrit-HasComments: Yes
