Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 )
Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc File src/kudu/tablet/delta_store.cc: http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc@211 PS1, Line 211: } I think it's worth adding here: } else { #ifndef NDEBUG CHECK(deleted_.empty()); CHECK(reinserted_.empty()); for (const UpdatesForColumn& ufc : updates_by_col_) { CHECK(ufc.empty()); } #endif } so that if we accidentally miss a case here we would crash in a DEBUG build http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc@212 PS1, Line 212: prepared_deltas_.clear(); this one can't go into the block above? -- To view, visit http://gerrit.cloudera.org:8080/13661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I799e81fef759d22f14d4530dbf0b250e0d7bc69b Gerrit-Change-Number: 13661 Gerrit-PatchSet: 1 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2019 16:50:53 +0000 Gerrit-HasComments: Yes
