ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 )
Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13661/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13661/2//COMMIT_MSG@9 PS2, Line 9: Add a variable for lazy initialization to accelerate DeltaMemStore scan > nit: no need to indent here Done http://gerrit.cloudera.org:8080/#/c/13661/2//COMMIT_MSG@11 PS2, Line 11: > I ran a benchmark of this patch with the original workload mentioned in the Thanks a lot :). About why CFileSet::Iterator::FinishBatch CPU cost goes up, I will watch your jira(KUDU-2866). http://gerrit.cloudera.org:8080/#/c/13661/2/src/kudu/tablet/delta_store.cc File src/kudu/tablet/delta_store.cc: http://gerrit.cloudera.org:8080/#/c/13661/2/src/kudu/tablet/delta_store.cc@214 PS2, Line 214: CHECK(deleted_.empty()); > nit: these lines are indented two extra spaces (we don't include the prepro My fault. Done -- To view, visit http://gerrit.cloudera.org:8080/13661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I799e81fef759d22f14d4530dbf0b250e0d7bc69b Gerrit-Change-Number: 13661 Gerrit-PatchSet: 3 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 07:05:49 +0000 Gerrit-HasComments: Yes
