ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 )
Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/13661/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13661/1//COMMIT_MSG@8 PS1, Line 8: > Doc for this feature. Done http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc File src/kudu/tablet/delta_store.cc: http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc@205 PS1, Line 205: // Lazy initialization. > I think we should add some doc here to show that this variable represents w Done http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc@211 PS1, Line 211: reinserted_.clear(); > I think it's worth adding here: Done http://gerrit.cloudera.org:8080/#/c/13661/1/src/kudu/tablet/delta_store.cc@212 PS1, Line 212: } else { > this one can't go into the block above? Here prepared_deltas_ is used for PREPARE_FOR_COLLECT but update_by_col_ ?deleted_ and reinserted_ is used for PREPARE_FOR_APPLY. For lazy init updates_by_col_, if we put prepared_deltas_ above, when in PREPARE_FOR_COLLECT mode, we will also init updates_by_col_. Maybe it is a waste of time? -- To view, visit http://gerrit.cloudera.org:8080/13661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I799e81fef759d22f14d4530dbf0b250e0d7bc69b Gerrit-Change-Number: 13661 Gerrit-PatchSet: 2 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 03:58:58 +0000 Gerrit-HasComments: Yes
