Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13661 )
Change subject: KUDU-2381: Optimize DeltaMemStore for case of no matching deltas. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13661/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13661/2//COMMIT_MSG@11 PS2, Line 11: > Thanks a lot :). About why CFileSet::Iterator::FinishBatch CPU cost goes u The cost didn't go up -- just that, percentage-wise, it went from 10->12% because the other costs went down. I put a patch here: https://gerrit.cloudera.org/c/13666/ and also about to post one to optimize our GetMemcmpableVarint64 -- To view, visit http://gerrit.cloudera.org:8080/13661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I799e81fef759d22f14d4530dbf0b250e0d7bc69b Gerrit-Change-Number: 13661 Gerrit-PatchSet: 3 Gerrit-Owner: ZhangYao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Yao Xu <[email protected]> Gerrit-Reviewer: ZhangYao <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2019 07:35:20 +0000 Gerrit-HasComments: Yes
