Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13820 )
Change subject: [docs] update the upgrade documentation ...................................................................... Patch Set 1: (7 comments) Could you push this change to a github fork so we can also review the rendered form of the documentation? http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@635 PS1, Line 635: . Prepare the software. This recommendation is only necessary if you're actually building from source. If not, it doesn't make sense. Could you condition it behind that? http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@636 PS1, Line 636: building build http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@638 PS1, Line 638: big large http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@645 PS1, Line 645: - Rolling restart `kudu-tserver` and the gflag above should be reset after every rebooting. Could you provide specific instructions for restoring the default gflag value? Also, when referring to kudu-master and kudu-tserver _processes_ (as opposed to binary names), no need to surround with backticks. Same with tserver below. http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@645 PS1, Line 645: rebooting reboot http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@648 PS1, Line 648: . Restore the original gflags. Likewise, this duplicates the suggestion on L645. http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@650 PS1, Line 650: WARNING: To prevent the restarted `tserver` from being evicted from the cluster, the gflag should be reset. Could you roll this into the rolling restart instructions? No need to duplicate the same suggestion. -- To view, visit http://gerrit.cloudera.org:8080/13820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b3e5c549dc05c3388c0b0dd628d205a356da344 Gerrit-Change-Number: 13820 Gerrit-PatchSet: 1 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Jul 2019 03:36:52 +0000 Gerrit-HasComments: Yes
