helifu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13820 )

Change subject: [docs] update the upgrade documentation
......................................................................


Patch Set 1:

(7 comments)

Here is a link to display the rendered form:
https://github.com/helifu/kudu/blob/master/docs/installation.adoc#upgrade
And I use "asciidoctor installation.adoc -b html" to verify it locally.

http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc
File docs/installation.adoc:

http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@635
PS1, Line 635: . Prepare the software.
> This recommendation is only necessary if you're actually building from sour
Done


http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@636
PS1, Line 636: building
> build
Done


http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@638
PS1, Line 638: big
> large
Done


http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@645
PS1, Line 645:   - Rolling restart `kudu-tserver` and the gflag above should be 
reset after every rebooting.
> Could you provide specific instructions for restoring the default gflag val
Done


http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@645
PS1, Line 645: rebooting
> reboot
Done


http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@648
PS1, Line 648: . Restore the original gflags.
> Likewise, this duplicates the suggestion on L645.
Done


http://gerrit.cloudera.org:8080/#/c/13820/1/docs/installation.adoc@650
PS1, Line 650: WARNING: To prevent the restarted `tserver` from being evicted 
from the cluster, the gflag should be reset.
> Could you roll this into the rolling restart instructions? No need to dupli
Done



--
To view, visit http://gerrit.cloudera.org:8080/13820
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b3e5c549dc05c3388c0b0dd628d205a356da344
Gerrit-Change-Number: 13820
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hzhel...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Priyanka Chheda <pchh...@cloudera.com>
Gerrit-Reviewer: helifu <hzhel...@corp.netease.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 08:26:27 +0000
Gerrit-HasComments: Yes

Reply via email to