Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 )
Change subject: KUDU-2635: treat failure to delete failed blocks as OK ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13858/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/13858/1/src/kudu/fs/log_block_manager.cc@2273 PS1, Line 2273: if (!s.ok() && !s.IsNotFound() && !s.IsDiskFailure()) { : if (first_failure.ok()) first_failure = s; : } else if (s.ok()) { : malloc_space += kudu_malloc_usable_size(lb.get()); : blocks_length += lb->length(); : lbs.emplace_back(std::move(lb)); nit: would it be easier to read if it were written the following way: if (PREDICT_TRUE(s.ok())) { ... } else if (s.IsNotFound() || s.IsDiskFailure()) { deleted->emplace_back(block_id); } else if (first_failure.ok()) { first_failure = s; } ? -- To view, visit http://gerrit.cloudera.org:8080/13858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Gerrit-Change-Number: 13858 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 17:34:53 +0000 Gerrit-HasComments: Yes
