Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 )
Change subject: KUDU-2635: treat failure to delete failed blocks as OK ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13858/1/src/kudu/tserver/tablet_server-test.cc File src/kudu/tserver/tablet_server-test.cc: http://gerrit.cloudera.org:8080/#/c/13858/1/src/kudu/tserver/tablet_server-test.cc@712 PS1, Line 712: WARN_NOT_OK nit: how much significance is in outputting this warning? If not much, maybe don't output it at all? http://gerrit.cloudera.org:8080/#/c/13858/1/src/kudu/tserver/tablet_server-test.cc@725 PS1, Line 725: SCOPED_TRACE(SecureDebugString(resp)); Is it going to be ever printed? If not, maybe drop this? -- To view, visit http://gerrit.cloudera.org:8080/13858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Gerrit-Change-Number: 13858 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 17:44:22 +0000 Gerrit-HasComments: Yes
