Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 )
Change subject: KUDU-2635: treat failure to delete failed blocks as OK ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Overall LGTM, just a few nits in the test. http://gerrit.cloudera.org:8080/#/c/13858/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/13858/2/src/kudu/fs/log_block_manager.cc@2277 PS2, Line 2277: s.IsDiskFailure() > We log in the RemoveLogBlockUnlocked() call that there's a disk error. Ah, indeed. -- To view, visit http://gerrit.cloudera.org:8080/13858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Gerrit-Change-Number: 13858 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 20:49:24 +0000 Gerrit-HasComments: Yes
