Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 )
Change subject: KUDU-2635: ignore failures to delete orphaned blocks ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13858/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13858/2//COMMIT_MSG@14 PS2, Line 14: blocks list will be empty. : : This patch addresses this by removing the blocks from the orphaned > Why did you choose to handle this in the LBM vs. the equivalent in TabletMe The TabletMetadata code is currently structured so we can easily persist that we've deleted 1) all orphaned blocks that didn't hit an error, or 2) all orphaned blocks. The code is structured as #1, and it is conservative in terms of error-checking by handling only errors that we might expect (not found, or disk failure). #2 is more along the lines of what you're suggesting; it's less conservative or more permissive because it ignores errors altogether. Though, the invariant in the TabletMetadata is that once DeleteOrphanedBlocks() is called, the orphaned blocks list is empty. So on second thought, I'm inclined to agree, and let's do this in DeleteOrphanedBlocks() to ensure that is true. Done -- To view, visit http://gerrit.cloudera.org:8080/13858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Gerrit-Change-Number: 13858 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2019 06:43:05 +0000 Gerrit-HasComments: Yes
