Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 )
Change subject: KUDU-2635: treat failure to delete failed blocks as OK ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13858/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13858/2//COMMIT_MSG@14 PS2, Line 14: This patch addresses this by treating such failures to delete blocks : from failed data directories as OK, from the stance of actually deleting : the block. For all intents and purposes, the blocks aren't coming back. Why did you choose to handle this in the LBM vs. the equivalent in TabletMetadata::DeleteOrphanedBlocks? To me it felt more natural for the LBM to "tell the truth" and for the TabletMetadata to ignore what the LBM said and to always remove all orphaned blocks from the superblock. -- To view, visit http://gerrit.cloudera.org:8080/13858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Gerrit-Change-Number: 13858 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2019 21:48:07 +0000 Gerrit-HasComments: Yes
