Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13858 )
Change subject: KUDU-2635: ignore failures to delete orphaned blocks ...................................................................... Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13858/4/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/13858/4/src/kudu/tablet/tablet_metadata.cc@521 PS4, Line 521: for (const BlockId& b : blocks) { : orphaned_blocks_.erase(b); : } > I don't see why it doesn't, but it doesn't. I see in http://www.cplusplus.c Well, the documentation says that the range [first; last) "must be a valid range in *this". So yeah maybe the iterator types need to be the same too. -- To view, visit http://gerrit.cloudera.org:8080/13858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Gerrit-Change-Number: 13858 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2019 23:59:32 +0000 Gerrit-HasComments: Yes
