Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13858 )
Change subject: KUDU-2635: ignore failures to delete orphaned blocks ...................................................................... KUDU-2635: ignore failures to delete orphaned blocks It was previously possible to leave some orphaned blocks in the in-memory orphaned blocks list by failing to delete some blocks due to a disk failure. Upon deleting a tablet with such orphaned blocks, Kudu could crash, as this breaks the assumption in the TabletMetadata that once we've made the call to delete orphaned blocks, then the orphaned blocks list will be empty. This patch addresses this by removing the blocks from the orphaned blocks list regardless of whether the blocks were deleted at the block manager level. At worst, this leaves us with untracked blocks, but it's better than crashing due to a bogus assumption. A test is added that passed 1/100 times when run on dist-test in debug mode with stress. With the patch, it passes 100/100 times. Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Reviewed-on: http://gerrit.cloudera.org:8080/13858 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/tablet/tablet_metadata.cc M src/kudu/tserver/tablet_server-test.cc 2 files changed, 31 insertions(+), 2 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ice78f41d6d367d42ad31c2127ceb5fc57a244e34 Gerrit-Change-Number: 13858 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <[email protected]>
