Hello Will Berkeley, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13897
to review the following change.
Change subject: version_util: allow period as delimiter for extra
......................................................................
version_util: allow period as delimiter for extra
This will permit versions like <major>.<minor>.<maintenance>.<vendor_ver>,
a common pattern used by at least one major Kudu vendor. This shouldn't have
any tangible effect on Kudu as we've always ignored the value of 'extra'.
I tried to reuse the string parsing but ended up with ugly looking code, so
I rewrote it as a DFA (i.e. poor man's regex).
Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7
---
M src/kudu/util/version_util-test.cc
M src/kudu/util/version_util.cc
M src/kudu/util/version_util.h
3 files changed, 83 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/13897/1
--
To view, visit http://gerrit.cloudera.org:8080/13897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7
Gerrit-Change-Number: 13897
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
