Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc@65 PS3, Line 65: .-] > nit: does '.' has special meaning in the set of acceptable characters? I s Hmm, you may be right; I removed the escaping and the unit tests still passed. Here's what the manpage says: To include a literal ']' in the list, make it the first character (following a possible '^'). To include a literal '-', make it the first or last character, or the second endpoint of a range. To use a literal '-' as the first endpoint of a range, enclose it in "[." and ".]" to make it a collating element (see below). With the exception of these and some combinations using '[' (see next paragraphs), all other special characters, including '\', lose their special significance within a bracket expression. -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2019 00:08:59 +0000 Gerrit-HasComments: Yes
