Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc File src/kudu/util/version_util.cc: http://gerrit.cloudera.org:8080/#/c/13897/3/src/kudu/util/version_util.cc@65 PS3, Line 65: * > nit: Should be a +? Or is "1.10.0-" considered valid? It's valid. The delimiter is chopped off and the 'extra' component is empty. From the unit test: { { "1.1.1-", 1, 1, 1, "" }, "1.1.1" }, (that's input, major, minor, maintenance, extra, and reassembled). -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 23:51:55 +0000 Gerrit-HasComments: Yes
