Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter in extra and tighten version syntax ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/13897/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13897/2//COMMIT_MSG@11 PS2, Line 11: Kudu > nit: upstream Kudu ? Done http://gerrit.cloudera.org:8080/#/c/13897/2//COMMIT_MSG@13 PS2, Line 13: the string parsing > Yeah, I thought about SplitStringPieceToVector(), SplitStringUsing(), and Ack http://gerrit.cloudera.org:8080/#/c/13897/2/src/kudu/util/version_util.h File src/kudu/util/version_util.h: http://gerrit.cloudera.org:8080/#/c/13897/2/src/kudu/util/version_util.h@50 PS2, Line 50: // The unsignedness is a style violation, but it allows the implementation to : // properly reject negative version numbers. > +1 I ended up reverting this back to signed ints because I could achieve the same thing using a regex. -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 23:31:59 +0000 Gerrit-HasComments: Yes
