Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13897 )
Change subject: version_util: allow period as delimiter for extra ...................................................................... Patch Set 2: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/13897/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13897/2//COMMIT_MSG@11 PS2, Line 11: Kudu nit: upstream Kudu ? http://gerrit.cloudera.org:8080/#/c/13897/2//COMMIT_MSG@13 PS2, Line 13: the string parsing Yeah, I thought about SplitStringPieceToVector(), SplitStringUsing(), and SplitStringAndParse from gutil/strings/split.h, but it seems the parser should be strict w.r.t. the '-' alternative separator to be only before the extra part and those functions are missing info on the delimiter they found per a parsed component. http://gerrit.cloudera.org:8080/#/c/13897/2/src/kudu/util/version_util.h File src/kudu/util/version_util.h: http://gerrit.cloudera.org:8080/#/c/13897/2/src/kudu/util/version_util.h@50 PS2, Line 50: // The unsignedness is a style violation, but it allows the implementation to : // properly reject negative version numbers. +1 With this, the artifact of the prior implementation became explicit :) I think the functionality is more important than the style guide in this context. -- To view, visit http://gerrit.cloudera.org:8080/13897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5502efa8ba378d96432e530366e74a82c83621f7 Gerrit-Change-Number: 13897 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 17:30:01 +0000 Gerrit-HasComments: Yes
