Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/13869/13/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/13869/13/src/kudu/client/predicate-test.cc@1169 PS13, Line 1169: LOG(FATAL) << "Invalid type"; > Log the value of GetParam() too. it's a C-style enum so we'll only see an integer, should I still do it? http://gerrit.cloudera.org:8080/#/c/13869/11/src/kudu/integration-tests/char-itest.cc File src/kudu/integration-tests/char-itest.cc: PS11: > If you want. I don't have a strong opinion. I guess I'll leave it here unless someone has a strong opinion to move it. I kinda find it clearer here in an itest, client-test is 6k+ LOC anyways. -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 13 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 23 Jul 2019 21:16:06 +0000 Gerrit-HasComments: Yes
