Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 17: (2 comments) LGTM, just please address the suggestion from TidyBot. http://gerrit.cloudera.org:8080/#/c/13869/17/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/13869/17/src/kudu/client/schema.h@89 PS17, Line 89: KuduColumnTypeAttributes(uint16_t length); > warning: single-argument constructors must be marked explicit to avoid unin Thank you for adding this new constructor. Adding 'explicit' as recommended by tidy bot will help to avoid surprises: please address TidyBot's suggestion. http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/integration-tests/char-itest.cc File src/kudu/integration-tests/char-itest.cc: http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/integration-tests/char-itest.cc@90 PS16, Line 90: ASSERT_OK(read.GetVarchar("value", &value)); > That wouldn't work due to this: https://github.com/apache/kudu/blob/de49f8e All right, it seems we assume there are no coercion for any pair of types, so CHAR to/from VARCHAR should not work the same as any other pair of types. -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 17 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 30 Aug 2019 16:43:16 +0000 Gerrit-HasComments: Yes
