Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 16: (4 comments) http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.h@85 PS16, Line 85: KuduColumnTypeAttributes(int8_t precision, int8_t scale, uint16_t length); Is this update with prior versions? I remember we strive to keep API/ABI compatibility, so older code would be compile with new versions of Kudu client library. http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.cc@346 PS16, Line 346: is not valid on a $0 column nit here and below in case of not applicable attributes: 'is not valid on a $0 column' --> 'is not applicable for column $0' http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.cc@408 PS16, Line 408: (data_->length) nit: it seems the two lines above also followed this pattern, but why parentheses are necessary? Maybe, drop them (and do that for those two lines above as well)? http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/integration-tests/char-itest.cc File src/kudu/integration-tests/char-itest.cc: http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/integration-tests/char-itest.cc@90 PS16, Line 90: ASSERT_OK(read.GetVarchar("value", &value)); Do we have a coverage for the cases when CHAR column values are read via VARCHAR-related accessors and vice versa? If not, does it make sense to add such? -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 16 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2019 18:35:43 +0000 Gerrit-HasComments: Yes
