Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/13869 )
Change subject: KUDU-1938 Add CHAR/VARCHAR to C++ client pt 2 ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.cc@346 PS16, Line 346: ->precision.value()) { > nit here and below in case of not applicable attributes: Done http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/client/schema.cc@408 PS16, Line 408: s::InvalidArgum > nit: it seems the two lines above also followed this pattern, but why paren Done http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/integration-tests/char-itest.cc File src/kudu/integration-tests/char-itest.cc: http://gerrit.cloudera.org:8080/#/c/13869/16/src/kudu/integration-tests/char-itest.cc@90 PS16, Line 90: ASSERT_OK(read.GetVarchar("value", &value)); > Do we have a coverage for the cases when CHAR column values are read via VA That wouldn't work due to this: https://github.com/apache/kudu/blob/de49f8e/src/kudu/client/scan_batch.cc#L219-L225 -- To view, visit http://gerrit.cloudera.org:8080/13869 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaf609565b0a0a87d6e645cd3ac14c0965af5ba8 Gerrit-Change-Number: 13869 Gerrit-PatchSet: 17 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 30 Aug 2019 14:26:00 +0000 Gerrit-HasComments: Yes
