Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Move some rebalancing logic from tools to master ...................................................................... Patch Set 1: (14 comments) http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/master/rebalance_algo.cc File src/kudu/master/rebalance_algo.cc: http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/master/rebalance_algo.cc@198 PS1, Line 198: random_device_(), > warning: initializer for member 'random_device_' is redundant [readability- Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/ksck-test.cc@67 PS1, Line 67: using kudu::master::ClusterCheckResult; > warning: using decl 'ClusterCheckResult' is unused [misc-unused-using-decls Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/ksck-test.cc@542 PS1, Line 542: const string& ref_id, > warning: parameter 'ref_id' is unused [misc-unused-parameters] Took out parameter in function signature and in function calls. http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/ksck_results.cc File src/kudu/tools/ksck_results.cc: http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/ksck_results.cc@61 PS1, Line 61: using kudu::master::ClusterStatus; > warning: using decl 'ClusterStatus' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/ksck_results.cc@180 PS1, Line 180: > (preemptive) TODO: fix the errant whitespaces in this file Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/placement_policy_util.cc File src/kudu/tools/placement_policy_util.cc: http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/placement_policy_util.cc@47 PS1, Line 47: //TODO: remove > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalance-test.cc File src/kudu/tools/rebalance-test.cc: http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalance-test.cc@32 PS1, Line 32: #include "kudu/tools/ksck_results.h" //TODO: remove > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalance-test.cc@33 PS1, Line 33: #include "kudu/tools/rebalancer.h" //TODO: remove > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalance-test.cc@46 PS1, Line 46: using kudu::master::ClusterLocalityInfo; > warning: using decl 'ClusterLocalityInfo' is unused [misc-unused-using-decl Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalance-test.cc@456 PS1, Line 456: //TODO: put this back in before the operator<< > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalancer.cc File src/kudu/tools/rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalancer.cc@57 PS1, Line 57: using kudu::client::KuduClient; > warning: using decl 'KuduClient' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalancer.cc@65 PS1, Line 65: using kudu::master::LocationBalancingAlgo; > warning: using decl 'LocationBalancingAlgo' is unused [misc-unused-using-de Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalancer.cc@66 PS1, Line 66: using kudu::master::RebalancingAlgo; > warning: using decl 'RebalancingAlgo' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14110/1/src/kudu/tools/rebalancer.cc@69 PS1, Line 69: using kudu::master::TwoDimensionalGreedyAlgo; > warning: using decl 'TwoDimensionalGreedyAlgo' is unused [misc-unused-using Done -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 1 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Aug 2019 15:28:52 +0000 Gerrit-HasComments: Yes
