Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Move some rebalancing logic from tools to master ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14110/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14110/2//COMMIT_MSG@15 PS2, Line 15: TODO: move tools/placement_policy_util and tools/rebalancer : into master too, so future auto-rebalancer task does not : rely on tools. > Yep, it makes sense to do so. Probably, it's best to do so in this changel Do you think it should be done in parts? ie. pt1 and pt2? I was concerned the patch would be too big if I submitted it all at once. http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/CMakeLists.txt@48 PS2, Line 48: rebalance_algo.cc > Agreed with Alexey. The rebalancing policy stuff is enough code that it pro Do you mean adding another directory like kudu/rebalance and moving all this code there? Or leaving this code in kudu/master but not in the master namespace, adding a target and library to kudu/master's CMakelists.txt? -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Aug 2019 18:10:06 +0000 Gerrit-HasComments: Yes
