Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14110 )
Change subject: Move some rebalancing logic from tools to master ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/CMakeLists.txt File src/kudu/master/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/14110/2/src/kudu/master/CMakeLists.txt@48 PS2, Line 48: rebalance_algo.cc > You might separate the rebalancing and replica placement stuff (i.e. placem Agreed with Alexey. The rebalancing policy stuff is enough code that it probably merits being a first class module, in its own subdirectory, with its own CMake library target. The namespacing should follow too (i.e. if you put this stuff in a new module called 'rebalancer', use kudu::rebalancer as the C++ namespace). -- To view, visit http://gerrit.cloudera.org:8080/14110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie0242a019cb44517539da2878cf889ee0c511964 Gerrit-Change-Number: 14110 Gerrit-PatchSet: 2 Gerrit-Owner: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 21 Aug 2019 18:01:29 +0000 Gerrit-HasComments: Yes
