Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/14114 )
Change subject: [util] Add ExtractFloat method to JsonReader and improve
ExtractDouble method
......................................................................
Patch Set 2:
The ASAN failure looks real:
[ RUN ] JsonReaderTest.SignedAndUnsignedInts
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/jsonreader.cc:230:38:
runtime error: 9.22337e+18 is outside the range of representable values of type
'long'
#0 0x7f6e43eb2c30 in
kudu::JsonReader::IsLosslessDoubleValue(rapidjson::GenericValue<rapidjson::UTF8<char>,
rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator> > const*) const
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/jsonreader.cc:230:38
#1 0x7f6e43eb27a6 in
kudu::JsonReader::ExtractDouble(rapidjson::GenericValue<rapidjson::UTF8<char>,
rapidjson::MemoryPoolAllocator<rapidjson::CrtAllocator> > const*, char const*,
double*) const
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/jsonreader.cc:148:7
#2 0x551130 in kudu::JsonReaderTest_SignedAndUnsignedInts_Test::TestBody()
/home/jenkins-slave/workspace/kudu-master/2/src/kudu/util/jsonreader-test.cc:212:3
--
To view, visit http://gerrit.cloudera.org:8080/14114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b
Gerrit-Change-Number: 14114
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 21 Aug 2019 18:02:20 +0000
Gerrit-HasComments: No
