Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14114 )
Change subject: [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/14114/2/src/kudu/util/jsonreader.cc File src/kudu/util/jsonreader.cc: http://gerrit.cloudera.org:8080/#/c/14114/2/src/kudu/util/jsonreader.cc@248 PS2, Line 248: return fabs(a-b) <= 1e-7; This seems to be one of the major differences from the rapidjson implementation. What issues exist with using the rapidjson implementation? -- To view, visit http://gerrit.cloudera.org:8080/14114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b Gerrit-Change-Number: 14114 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Aug 2019 20:23:56 +0000 Gerrit-HasComments: Yes
