Hello Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14114
to look at the new patch set (#3).
Change subject: [util] Add ExtractFloat method to JsonReader and improve
ExtractDouble method
......................................................................
[util] Add ExtractFloat method to JsonReader and improve ExtractDouble method
ExtractDouble method should not only parse double values, int values
that can be losslessly converted to double should also be parsed.
Though there is already IsLosslessFloat() in rapidjson library,
the implementation has some precision issues.
This patch re-implement the method.
Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b
---
M src/kudu/tools/tool_action_table.cc
M src/kudu/util/jsonreader-test.cc
M src/kudu/util/jsonreader.cc
M src/kudu/util/jsonreader.h
4 files changed, 89 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/14114/3
--
To view, visit http://gerrit.cloudera.org:8080/14114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b
Gerrit-Change-Number: 14114
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
