Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14114 )
Change subject: [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method ...................................................................... [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method ExtractDouble method should not only parse double values, int values that can be losslessly converted to double should also be parsed. Though there is already IsLosslessFloat() in rapidjson library, the implementation has some precision issues. This patch re-implement the method. Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b Reviewed-on: http://gerrit.cloudera.org:8080/14114 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/tools/tool_action_table.cc M src/kudu/util/jsonreader-test.cc M src/kudu/util/jsonreader.cc M src/kudu/util/jsonreader.h 4 files changed, 102 insertions(+), 12 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b Gerrit-Change-Number: 14114 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]>
