Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14114 )
Change subject: [util] Add ExtractFloat method to JsonReader and improve ExtractDouble method ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14114/3/src/kudu/util/jsonreader.cc File src/kudu/util/jsonreader.cc: http://gerrit.cloudera.org:8080/#/c/14114/3/src/kudu/util/jsonreader.cc@164 PS3, Line 164: lue( > nit: missing newline? Done -- To view, visit http://gerrit.cloudera.org:8080/14114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica0a04fb21daceaa44233995a42a60686f59361b Gerrit-Change-Number: 14114 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 23 Aug 2019 07:00:59 +0000 Gerrit-HasComments: Yes
