Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/14140/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14140/4//COMMIT_MSG@14 PS4, Line 14: extra space http://gerrit.cloudera.org:8080/#/c/14140/4//COMMIT_MSG@14 PS4, Line 14: enableing enabling http://gerrit.cloudera.org:8080/#/c/14140/4//COMMIT_MSG@14 PS4, Line 14: loggin logging http://gerrit.cloudera.org:8080/#/c/14140/4/java/kudu-jepsen/src/test/resources/kudu.flags File java/kudu-jepsen/src/test/resources/kudu.flags: http://gerrit.cloudera.org:8080/#/c/14140/4/java/kudu-jepsen/src/test/resources/kudu.flags@29 PS4, Line 29: --alsologtostderr Why is it necessary to add this flag? Could you add a small comment with explanation? http://gerrit.cloudera.org:8080/#/c/14140/4/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/14140/4/src/kudu/util/flags.cc@a194 PS4, Line 194: Why to remove this comment? The flag is controlled by glog library, not Kudu code. Does it mean --alsologtostderr flag is no longer deprecated by --stderrthreshold in libglog() ? http://gerrit.cloudera.org:8080/#/c/14140/4/src/kudu/util/flags.cc@196 PS4, Line 196: stable What is the motivation to switch from hidden to 'stable'? I'm not sure it's the right thing to do given the current its current deprecation status in glog. https://github.com/apache/kudu/blob/8af4883be0d49d4fe69ef697345d1feee799c935/src/kudu/util/flag_tags.h#L21-L25 -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 4 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 25 Aug 2019 23:44:02 +0000 Gerrit-HasComments: Yes
