Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14140/4/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/14140/4/src/kudu/util/flags.cc@196 PS4, Line 196: hidden > What is the motivation to switch from hidden to 'stable'? I'm not sure it' I was trying to create a new flag, but I found in glog about alsologtostrerr https://github.com/google/glog/blob/master/src/logging.cc#L108 and stderrthreshold will just obsoletes --alsologtostderr, but alsologtostderr still workers, so we good to use right? https://github.com/google/glog/blob/master/src/logging.cc#L124 Please let me know, If I'm wrong -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 7 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2019 03:51:24 +0000 Gerrit-HasComments: Yes
