Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14140/4/java/kudu-jepsen/src/test/resources/kudu.flags File java/kudu-jepsen/src/test/resources/kudu.flags: http://gerrit.cloudera.org:8080/#/c/14140/4/java/kudu-jepsen/src/test/resources/kudu.flags@29 PS4, Line 29: --alsologtostderr > Why is it necessary to add this flag? Could you add a small comment with e I think there is no need here! will verify once. http://gerrit.cloudera.org:8080/#/c/14140/4/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/14140/4/src/kudu/util/flags.cc@196 PS4, Line 196: stable > What is the motivation to switch from hidden to 'stable'? I'm not sure it' as it was in hidden, I was in the assumption of the flag is not been used. thought of using it for enabling logging for both stderr and str dir, as name suited for it. should I create a new flag then? .ie Bool logtostderr_and_logdir ? -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 4 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Sun, 25 Aug 2019 23:51:16 +0000 Gerrit-HasComments: Yes
