Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/14140 )
Change subject: KUDU-2877 Support logging to files and stderr at the same time ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc File src/kudu/util/logging.cc: http://gerrit.cloudera.org:8080/#/c/14140/7/src/kudu/util/logging.cc@228 PS7, Line 228: if (!FLAGS_logtostderr) { > There is some logic that may need to be updated to handle logging both plac I have updated the PR with creating a new flag(not tested yet), but I found in glog about alsologtostderr https://github.com/google/glog/blob/master/src/logging.cc#L108 and stderrthreshold will just obsoletes --alsologtostderr, but alsologtostderr still workers, so we good to use right? https://github.com/google/glog/blob/master/src/logging.cc#L124 Why can't we use alsologtostderr ? -- To view, visit http://gerrit.cloudera.org:8080/14140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58117a587cdca868e240897938964d68d50ddd5b Gerrit-Change-Number: 14140 Gerrit-PatchSet: 7 Gerrit-Owner: Sandish Kumar HN <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Sandish Kumar HN <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2019 21:32:11 +0000 Gerrit-HasComments: Yes
