Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 8: Code-Review+1 (4 comments) I removed -1 vote due to strange IWYU issue. This looks good to me. Maybe, Adar has some feedback as well. http://gerrit.cloudera.org:8080/#/c/14128/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14128/7//COMMIT_MSG@14 PS7, Line 14: In Kudu, when we want to check whether tables are balanced or not on : tservers, and how many replicas distributed > Done Great, thanks a lot! http://gerrit.cloudera.org:8080/#/c/14128/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14128/8//COMMIT_MSG@10 PS8, Line 10: it nit: it's http://gerrit.cloudera.org:8080/#/c/14128/8//COMMIT_MSG@11 PS8, Line 11: add nit: adds http://gerrit.cloudera.org:8080/#/c/14128/8/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14128/8/src/kudu/util/metrics.h@785 PS8, Line 785: template<typename T> : friend class GaugePrototype; : FRIEND_TEST(MetricsTest, TestDumpOnlyChanged); It seems IWYU incorrectly processes this. I think we can ignore that. Or, if it looks too messy to you, I'm OK keeping InvalidEpoch() public, but it's all up to you :) -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 8 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 06 Sep 2019 06:48:42 +0000 Gerrit-HasComments: Yes
