Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/14128/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14128/9//COMMIT_MSG@11 PS9, Line 11: merged_entities_count_of_<entity> > Could we just name it 'merged_entities_count'? The entity type is implied f Metrics defined by METRIC_DEFINE_gauge_size(name, merged_entities_count,..) is named METRIC_merged_entities_count, and METRIC_DEFINE_entity(name) is called in global scope, so there will be multiple definition of METRIC_merged_entities_count if we do it like this. http://gerrit.cloudera.org:8080/#/c/14128/9/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14128/9/src/kudu/util/metrics.h@905 PS9, Line 905: : // Instantiate a "manual" gauge and hidden it, it will appear : // when it update, or in the new merged entity. > "Instantiate a "manual" gauge and hide it. It will appear when its value is Done -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 9 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 07 Sep 2019 01:45:07 +0000 Gerrit-HasComments: Yes
