Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/14128/11/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14128/11/src/kudu/util/metrics.h@256 PS11, Line 256: // IWYU pragma: no_forward_declare kudu::MetricPrototype : // IWYU pragma: no_forward_declare kudu::MetricPrototype::CtorArgs : // IWYU pragma: no_forward_declare kudu::MetricUnit > I've tried to make InvalidateEpoch() public again, but it didn't work, IWYU Whoops, indeed. This IWYU's glitch is annoying, probably it will be better with newer IWYU's version. For now, let's add this file into the IWYU's suppression list. -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 11 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 19:00:43 +0000 Gerrit-HasComments: Yes
