Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14128 )

Change subject: [metrics] Add a metric to count merged entities when merge 
metrics
......................................................................


Patch Set 10:

> Last time I manually overrode -1 from Jenkins due to IWYU failure.  I can do 
> it this time as well.

That just passes the pain along: the next person to touch metrics.h will see 
the exact same failure.

> An alternative route is to make InvalidateEpoch() public, as it was before.

Let's do this instead.


--
To view, visit http://gerrit.cloudera.org:8080/14128
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1
Gerrit-Change-Number: 14128
Gerrit-PatchSet: 10
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Comment-Date: Tue, 10 Sep 2019 02:41:14 +0000
Gerrit-HasComments: No

Reply via email to