Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 11: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14128/11/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14128/11/src/kudu/util/metrics.h@256 PS11, Line 256: // IWYU pragma: no_forward_declare kudu::MetricPrototype : // IWYU pragma: no_forward_declare kudu::MetricPrototype::CtorArgs : // IWYU pragma: no_forward_declare kudu::MetricUnit Ah, that's nice. But it seems this is not enough to help out IWYU with its glitch. It seems there only way around is to make InvalidateEpoch() public. As I understand, Adar is advocating for resolving it this way, and I'm OK with that as well. Sorry to see IWYU gives so much trouble with making some methods of template classes non-public :( -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 11 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 17:11:52 +0000 Gerrit-HasComments: Yes
