Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14128 )
Change subject: [metrics] Add a metric to count merged entities when merge metrics ...................................................................... Patch Set 12: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/14128/12/src/kudu/util/metrics.h File src/kudu/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/14128/12/src/kudu/util/metrics.h@255 PS12, Line 255: : // IWYU pragma: no_forward_declare kudu::MetricPrototype : // IWYU pragma: no_forward_declare kudu::MetricPrototype::CtorArgs : // IWYU pragma: no_forward_declare kudu::MetricUnit Should we remove this? -- To view, visit http://gerrit.cloudera.org:8080/14128 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I652b457a2df73414f95f5d1d5efaa003cc262bd1 Gerrit-Change-Number: 14128 Gerrit-PatchSet: 12 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 19:01:08 +0000 Gerrit-HasComments: Yes
